Version 1.4.1 - No value has been specified for property 'bundleIdentifier'

muvixalex · December 6, 2017, 8:37am

Hi, when upgraded gradle plugin from 1.4.0 to 1.4.1 I’m getting an error in gradle build (IPA):
No value has been specified for property ‘bundleIdentifier’

Do I need to update something? Are there migration steps?

vighr · December 6, 2017, 9:00am

Hi!

Which xcode version are used? Are you opened project in the xcode, Bundle Identifier is empty?

Best Regards,
Roland

muvixalex · December 6, 2017, 9:13am

Xcode 9.1.
In Xcode Bundle Identifier is not empty.

Noisyfox · December 7, 2017, 5:52am

The “PRODUCT_BUNDLE_IDENTIFIER” key doesn’t appear in ‘./build/moe/xcodebuild/XcodeBuild-xxx-xxx-xxx.properties’ which is required by here:

github.com

multi-os-engine/moe-plugin-gradle/blob/moe-master/src/main/java/org/moe/gradle/tasks/IpaBuild.java#L625


    if (workspace == null) {
        return null;
    }
    return resolvePathRelativeToRoot(getProject().file(workspace));
});
addConvention(CONVENTION_BUNDLE_IDENTIFIER, () -> {
    final Map<String, String> buildSettings = xcodeBuildTask.getNullableXcodeBuildSettings();
    if (buildSettings == null) {
        return null;
    }
    final String bundleIdentifier = buildSettings.get(BUNDLE_IDENTIFIER_KEY);
    return bundleIdentifier;
});


addConvention(CONVENTION_EXPORT_METHOD, ext.ipaExport::getMethod);
setUploadBitcode(ext.ipaExport.getUploadBitcode());
setUploadSymbols(ext.ipaExport.getUploadSymbols());
setCompileBitCode(ext.ipaExport.getCompileBitcode());
setEmbedOnDemandResourcesAssetPacksInBundle(ext.ipaExport.getEmbedOnDemandResourcesAssetPacksInBundle());
addConvention(CONVENTION_EXPORT_ICLOUD, ext.ipaExport::getICloudContainerEnvironment);
addConvention(CONVENTION_EXPORT_DEMAND_RESOURCES_BASE_URL, ext.ipaExport::getOnDemandResourcesAssetPacksBaseURL);

Noisyfox · December 7, 2017, 6:58am

Alright it turned out that the bundle identifier is hardcoded inside info.plist instead of PRODUCT_BUNDLE_IDENTIFIER in .xcodeproj file.

After adding this value in .xcodeproj file peoperly, it should fix this issue.

muvixalex · December 10, 2017, 8:11am

Unfortunately this is not working for me, it brings back the original problem that I had for which I removed the Bundle Identifier from the xcodeproject and it solved it, has to do with code signing, it was a workaround for a problem when xcode project signing is set to automatic, but in the gradle build script I must specify the provisioning profile manually (otherwise it’s not being signed with the distribution key, so I can’t upload to app store).

The specific error is:

Code Signing Error: [***] has conflicting provisioning settings. [***] is automatically signed, but provisioning profile [***] has been manually specified. Set the provisioning profile value to “Automatic” in the build settings editor, or switch to manual signing in the project editor.
Code Signing Error: Code signing is required for product type ‘Application’ in SDK ‘iOS 11.1’

muvixalex · December 10, 2017, 9:31am

Actually this seems to be working fine with this version if I do what you suggested and remove the signing identity in the gradle build script.

Noisyfox · December 10, 2017, 11:07pm

Yeah if the Automatic mode works for you, then you should only specify the dev team in your gradle